Fix Enchantment registration issues

TheBusyBiscuit commented 4 years ago

Short Description

This fixes the Exception which is thrown when the Enchantment is already registered (usually only on reloads). While reloading itself is discouraged, we can and might still fix this exception.

Also updated to RC-17, included the LICENSE in the compiled jar, finally implemented bStats properly.

Related Issues

No currently open Issues I think

Checklist

[x] I have fully tested the proposed changes and promise that they will not break everything into chaos.
[x] I have also tested the proposed changes in combination with base Slimefun and made sure nothing breaks/unexpected happens.
[x] I followed the existing code standards and didn't mess up the formatting.
[ ] I did my best to add documentation to any public classes or methods I added which may not be obvious to maintainers.
[ ] I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values

J3fftw1 commented 4 years ago

Please dont change the way our imports are listed will dl a full review tommorow

TheBusyBiscuit commented 4 years ago

I only removed unused imports for the most part, in many classes you are importing like 10 classes that you don't even use. In some occasion the import order might be slightly changed, but mostly it's the removal of unused imports. I suggest to leave it like that, since you are enforcing the google java style guide as per contributing.md I wanted to PR an auto-import fix github workflow next anyway, so you won't ever need to worry about imports anyway, neither unused nor order.

J3fftw1 commented 4 years ago

The auto-import workflow would be great And what contributing.md are you talking about

TheBusyBiscuit commented 4 years ago

Oh nevermind, you don't have that file. I was referencing this comment: https://github.com/J3fftw1/LiteXpansion/pull/48#issuecomment-687542230

J3fftw1 commented 4 years ago

Okay then lets leave it like this also could you link me to the workflow i wanna read up on it

TheBusyBiscuit commented 4 years ago

I already made a PR for it #92 It just runs the official Google Java Formatting jar from Google with the "fix-imports-only" setting.

J3fftw1 commented 4 years ago

Conflicts

TheBusyBiscuit commented 4 years ago

Any weird imports, the workflow will take care of :P

TheBusyBiscuit commented 4 years ago

See :D

J3fftw1 / LiteXpansion