search

J535D165 / cbsodata

Unofficial Statistics Netherlands (CBS) open data API client for Python
http://cbsodata.readthedocs.io/
MIT License
42 stars 17 forks source link

Update cbsodata3.py #11

Closed ncvanegmond closed 5 years ago

ncvanegmond commented 5 years ago

added positional arguments for functions get_table_list and _download_metadata to allow for use of proxies

J535D165 commented 5 years ago

Great implementation.

The tests fail due to style errors https://travis-ci.org/J535D165/cbsodata/jobs/581151465. Thereafter, I can merge.

Would you like to have a new release on the short term?

(FYI @jolienoomens)

ncvanegmond commented 5 years ago

Thanks for considering the PR, and all your feedback and patience. First time making a pull requests, so figuring it out as I go :) Think I got all errors this time around.

If you would be able to do a new release on the short-term, that would be much appreciated! Very helpful library, even more so now we can use it behind a proxy ;)

J535D165 commented 5 years ago

Thanks, merged and a new release on PyPI. Good work for your first PR!

Note. Add support for proxies in odata4 #8.