search

J7mbo / twitter-api-php

The simplest PHP Wrapper for Twitter API v1.1 calls
MIT License
1.82k stars 800 forks source link

Clear the current get and post fields after a request has been processed - This saves having to reinstatement TwitterAPIExchange for every API call. #168

Closed aran112000 closed 8 years ago

aran112000 commented 8 years ago

Clear the current get and post fields after a request has been processed - This saves having to reinstatement TwitterAPIExchange for every API call.

Previously if you were performing a GET call and then a POST call an exception would be thrown because you can't have both get and set fields present. This resolves this bug.

BugHunter2k commented 8 years ago

Discussed here: https://github.com/J7mbo/twitter-api-php/issues/150 There was no further comment on that from J7mbo

J7mbo commented 8 years ago

I'm a little worried about affecting BC with this... if we choose to merge it in and it'll have to go on the release note as a potentially BC breaking change?

J7mbo commented 8 years ago

Also, the PR needs to be made onto the development branch

BugHunter2k commented 8 years ago

I don't see any problems with BC here. If you worry my be we can add an option to the constructor to enable/disable clearing the fields which defaults to disable.

aran112000 commented 8 years ago

I'll close this pull request off and re-submit under the development branch

aran112000 commented 8 years ago

New pull request can be found here for reference: https://github.com/J7mbo/twitter-api-php/pull/169