search

JACOBSMILE / tmodloader1.4

An easy to configure Docker Image for tModLoader 1.4 servers.
Other
139 stars 33 forks source link

Fix serverconfig path #8

Closed riboyama closed 1 year ago

riboyama commented 1 year ago

Change config.txt to serverconfig.txt

riboyama commented 1 year ago

@JACOBSMILE Could you merge this anytime soon?

JACOBSMILE commented 1 year ago

Hi @riboyama

I'll need to update the README to reflect, the better change would be to update the first check to reflect the readme, making it "config.txt" across the board and not "serverconfig.txt".

Anyways, I will be able to review and resolve it this evening after work. Thanks! 👍

riboyama commented 1 year ago

Ah nice! I had some trouble mounting the confix.txt since this check is in entrypoint: https://github.com/JACOBSMILE/tmodloader1.4/blob/1775cbf1e72f36103d1c271416d6f0bf5647dc0a/entrypoint.sh#L6

However the startup command uses: https://github.com/JACOBSMILE/tmodloader1.4/blob/1775cbf1e72f36103d1c271416d6f0bf5647dc0a/entrypoint.sh#L92

I think it may be better to rename everything to serverconfig.txt, as that is also what terraria uses by default

JACOBSMILE commented 1 year ago

I fixed this in the most recent commit to the master branch, so I am going to close this PR.