JADE-V-V / JADE

JADE, a novel nuclear data libraries V&V tool
GNU General Public License v3.0
23 stars 8 forks source link

[Feature request] - An utility is needed to put weight windows files that are distributed separately into the proper folders #237

Open AlbertoBittes opened 7 months ago

AlbertoBittes commented 7 months ago

Is your feature request related to a problem? Please describe. In the new release WW files will be stored in the same folder as the original input, while before they were all together in a single folder

Describe the solution you'd like An utility is needed to place such files in the correct folders once the user receives the WW package

JezSw commented 7 months ago

@AlbertoBittes I just scanned this and wasn't quite clear what the logic of this is? I'm assuming the output should be be something like:

- input_dir
|- input_1
|- input_2
\- weighted_windows
 |- input_weight_1
 |- input_weight_2

And I'm guessing the inputs will be: input_dir (from above without the weighted dir) weighted_window_dir (as recieved?)

Mainly asking as if this is defined I might be able to help if I have some time.

AlbertoBittes commented 7 months ago

@AlbertoBittes I just scanned this and wasn't quite clear what the logic of this is? I'm assuming the output should be be something like:

- input_dir
|- input_1
|- input_2
\- weighted_windows
 |- input_weight_1
 |- input_weight_2

And I'm guessing the inputs will be: input_dir (from above without the weighted dir) weighted_window_dir (as recieved?)

Mainly asking as if this is defined I might be able to help if I have some time.

I think that you can make a proposal for the original folder to be stored in our servers and the final folder structure. I suggest that mcnp input files and weight windows files should stay in the same folder

dodu94 commented 7 months ago

I'll jump in quickly here to clarify a few points. The new structure (which I would not change again) foresees that ww files, if present, need to be put in the same folder of the inputs they refer to. Since ww files are heavy, we cannot put them in GitHub, but we need to store there somewhere else and then send it to users when they ask for them. What Alberto suggests is: 1) decide a folder structure to store the ww file (it could even be a simple folder containing all of them with specific name convention for the files 2) once the cold repo structure is chosen, develop an utility that takes the cold repo (a folder) and copies all the ww files in the respective folders of the JADE structure (i.e., where their respective input is located)

dodu94 commented 1 month ago

EDIT: it appears that maybe we can store the WW files directly with git using git large files. To be confirmed.