search

JADES-GTO / JAGUAR_extragalactic_mock_catalog

3 stars 0 forks source link

Galaxy sizes #9

Open OlivierKauffmann opened 6 years ago

OlivierKauffmann commented 6 years ago

I notice a couple mistakes (typos) in the paper concerning galaxy size computation.

christinawilliams commented 6 years ago

Dear Olivier,

Many thanks for catching these typos. In equation 24, you are correct that B_H(M) should be 10^B_H(M). In equation 26 there was some issue with the parentheses, and the correct formula is P(R|M,z) propto exp(-y^2/2) F where F = 1+ [ h3 (2 sqrt(2) y^3 - 3 sqrt(2) y) / sqrt(6) ]

Please let me know if you have further questions! Thanks, Christina

On Wed, Oct 24, 2018 at 9:21 AM OlivierKauffmann notifications@github.com wrote:

I notice a couple mistakes (typos) in the paper concerning galaxy size computation.

  • The parameter B_H(M) for star-forming z<4 galaxies (eq.24) should be 10 to the indicated formula (otherwise we get negative radii for M<7).
  • In in eq.26 either some parentheses are missing or they are too many. In any case, the exact expression is not clear.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/JADES-GTO/JAGUAR_extragalactic_mock_catalog/issues/9, or mute the thread https://github.com/notifications/unsubscribe-auth/AKP9CL-aoAWVfyO887znhixY6jQnlAHXks5uoGlYgaJpZM4X36Kv .

--

Christina C. Williams NSF Postdoctoral Fellow University of Arizona 933 N. Cherry Ave Tucson, AZ 85721 (520) 621-4661

jacopo-chevallard commented 6 years ago

@christinawilliams @kevinhainline @eclake do you think it's worth adding an Erratum to the paper to correct the above equations?

OlivierKauffmann commented 5 years ago

These expressions look more similar to what can be found in van der Marel & Franx 1993. I have implemented them and I found that the probability distribution is sometimes negative (see below the probability distribution, with Reff in kpc on the x-axis). Changing the sign of h3 does not seem to solve the problem. Are you sure about this is what you implemented ? Did you truncate the profile at the first negative value (going from left to right) or did anything similar ? reff_distribution

christinawilliams commented 5 years ago

Dear Olivier,

Our version does not produce negative values. Is it helpful if we send you the subroutine to generate the sizes?

Christina

On Fri, Nov 23, 2018 at 7:06 AM OlivierKauffmann notifications@github.com wrote:

These expressions look more similar to what can be found in van der Marel & Franx 1993. I have implemented them and I found that the probability distribution is sometimes negative. Are you sure about this is what you implemented ? Changing the sign of h3 does not seem to solve the problem. [image: reff_distribution] https://user-images.githubusercontent.com/38685988/48947371-3c5d8d00-ef31-11e8-90c6-c8fd09be4917.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/JADES-GTO/JAGUAR_extragalactic_mock_catalog/issues/9#issuecomment-441249316, or mute the thread https://github.com/notifications/unsubscribe-auth/AKP9CHhRLVIxUtzmU3Jzy81tX2_kSRtGks5uyADLgaJpZM4X36Kv .

--

Christina C. Williams NSF Postdoctoral Fellow University of Arizona 933 N. Cherry Ave Tucson, AZ 85721 (520) 621-4661

OlivierKauffmann commented 5 years ago

Dear Christina,

Yes, I think this would help. Thank you

Olivier