search

JAM-Software / RibbonFramework

Delphi wrapper and standalone Designer for the Windows Ribbon Framework
Other
204 stars 59 forks source link

Support VCL styles #86

Open markwilliams1234 opened 6 years ago

markwilliams1234 commented 6 years ago

untitled I have noticed two different problems with loading styles (either as default or whilst running an app). In the case of the Textpad 06 sample app, if you load a style by default or choose a new style whilst running you lose the quick access toolbar and you also get a space above the ribbon (see attached png).

In an app of my own, if I set a style by default, I have found I get different problems with different forms:

The Main form - works fine (including the quick access toolbar is visible), but the form frame does not adopt the chosen style. Subsidiary forms present the same issues as the textpad form.

I can't see any significant difference between the main form in my app and the Textpad app.

markwilliams1234 commented 6 years ago

I have discovered the difference between the two apps. A styled form will show the quick access toolbar if you turn off seBorder in its style elements. However, then the frame and caption do not get styled. If you don't turn them off, you lose the quick access toolbar and get a blank space above the ribbon.

joachimmarder commented 6 years ago

I don't think that VCL styles and the Windows Ribbon Framework are compatible. The Windows Ribbon framework is basically an embedded ActiveX control that does some additional magic in the window title, I don't think it can be themed, it will be themed according to the Windows version. I also tried if https://github.com/RRUZ/vcl-styles-utils helps, but it did not change anything. Maybe explicit support needs to be added here for the Windows Ribbon Framework window classes.

markwilliams1234 commented 6 years ago

For time being then it would seem sensible to disable styles for form frame. Shame. Thanks