search

JANUS-Institute / HallThrusterPEM

Prototype of a predictive engineering model (PEM) of a Hall thruster, integrating physics-based sub-models with uncertainty quantification.
https://janus-institute.github.io/HallThrusterPEM/
GNU General Public License v3.0
2 stars 1 forks source link

Updata JSON input for HallThruster.jl #9

Closed archermarx closed 5 months ago

archermarx commented 5 months ago

*Update

I've simplified HallThruster.jl's input JSON handling. It now uses a single section. I've also added a few new options:

Additions

  1. A ShiftedGaussianBohm model with four parameters
  2. A switch apply_thrust_divergence_correction for turning on and off divergence modeling in HallThruster.jl
  3. A neutral_ingestion_multiplier for increasing the amount of neutrals ingested in the thruster

I've also removed the solve_background_neutrals key, as that is no longer used in HallThruster.jl.

Lastly, I've bumped the Julia version to 1.10 and the HallThruster.jl version to 0.14. That version will be tagged shortly over on the HallThruster.jl repo.

eckelsjd commented 5 months ago

The config file used with hallthruster_jl_wrapper() must be consistent with the inputs passed to it; this is why the test case was failing.

When you want to change what inputs are actually being passed to hallthruster_jl_wrapper, you can pass in a new config file that has your required_inputs set to the variable ids from your variables.json file. The default_inputs is just a convenience to load nominal values from variables.json even if you don't specify them in required_inputs.

archermarx commented 5 months ago

yay the tests pass!