JASchilz / AnkiSyncDuolingo

Pull your Duolingo vocabulary into Anki, as an Anki plugin
MIT License
101 stars 10 forks source link

Always adds to the default deck, even if it is renamed #67

Closed jameskraus closed 1 year ago

jameskraus commented 1 year ago

A potential resolution to https://github.com/JASchilz/AnkiSyncDuolingo/issues/56. Grabs the default deck by ID instead of by name. This way, it can add to the default deck even if the user renames it.

I was inspired to open this PR because I renamed by default deck to "zDefault" so it would show at the bottom of my list. Before this change, the "Default" deck would be created by AnkiSyncDuolingo, but it would add the cards to the "zDefault" deck.

This PR is one attempt at solving the problem, but I can imagine its behavior may still be confusing. For example in https://github.com/JASchilz/AnkiSyncDuolingo/issues/56 the user renamed the deck to something else, and their cards were getting added to that deck instead of "Default". This PR would just make the cards sync to the renamed default deck without creating an empty "Default" deck, which is especially confusing if the user doesn't remember they renamed the default deck.

Some alternative solutions which may be better than this PR:

JASchilz commented 1 year ago

Looks like a strict improvement over the current strategy.