search

JAndrassy / ArduinoOTA

Arduino library to upload sketch over network to Arduino board with WiFi or Ethernet libraries
GNU Lesser General Public License v2.1
450 stars 91 forks source link

Update WiFiOTA.cpp #117

Closed figital closed 2 years ago

figital commented 2 years ago

Un-harcoding the username.

JAndrassy commented 2 years ago

name is something else

figital commented 2 years ago

Why would the username be hardcoded to "arduino"?

JAndrassy commented 2 years ago

Why would the username be hardcoded to "arduino"?

there are no users. it is only one password.

figital commented 2 years ago

In the demo code for this library there is a username and a password .... (line 45).

https://github.com/jandrassy/ArduinoOTA/blob/master/examples/OTEthernet/OTEthernet.ino

... some users might not want to use this username. (We do not).

JAndrassy commented 2 years ago

it is no a username. it is the name of the network port

figital commented 2 years ago

i see what you are saying. thank you for clarifying!

why shouldn't i be able to change the name of the network port?

JAndrassy commented 2 years ago

i see what you are saying. thank you for clarifying!

why shouldn't i be able to change the name of the network port?

if you have more arduinos with network port (and IP addresses assigned by DHCP)