search

JAndrassy / ArduinoOTA

Arduino library to upload sketch over network to Arduino board with WiFi or Ethernet libraries
GNU Lesser General Public License v2.1
435 stars 89 forks source link

Fix mDNS not working when using handle() and not poll() #216

Closed tomer-w closed 1 year ago

tomer-w commented 1 year ago

As there was no override to the handle() function on the ArduinoOTAMdnsClass class then the base class function was called and it didnt handle the mDNS functionality.

JAndrassy commented 1 year ago

good catch. Other fix could be to make poll virtual. I am undecided yet which way is better.