JAndrassy / ArduinoOTA

Arduino library to upload sketch over network to Arduino board with WiFi or Ethernet libraries
GNU Lesser General Public License v2.1
435 stars 89 forks source link

Renesas get stuck in `InternalStorage.open()` #217

Closed vshymanskyy closed 11 months ago

vshymanskyy commented 11 months ago

debugPrint():

storageStartAddress 22000
SKETCH_START_ADDRESS 4000
MAX_FLASH 40000

I call InternalStorage.open(56296) directly. AFAIK, the call freezes inside https://github.com/JAndrassy/ArduinoOTA/blob/f88941c166e7c5ca475f3393565ac553879df586/src/utility/r_flash_lp_cf.c#L424

vshymanskyy commented 11 months ago

@JAndrassy please take a look

JAndrassy commented 11 months ago

I tested

#include <ArduinoOTA.h>
void setup() {
  Serial.begin(115200);
  Serial.println("TEST START");
  InternalStorage.debugPrint();
  InternalStorage.open(56296);
  InternalStorage.close();
  Serial.println("TEST OK");
}
void loop() {
}

and the output is

TEST START
storageStartAddress 22000
SKETCH_START_ADDRESS 4000
MAX_FLASH 40000
TEST OK

so I can't reproduce the problem.

EDIT: I tested with IDE1, IDE2 and Eclipse Sloeber builds

vshymanskyy commented 11 months ago

Thanks! Looks like I crashed my board and it was completely unrelated to ArduinoOTA. I can confirm that OTA works:

[16234] OTA chunk @  c400, size: 1024, crc: 3cf30dc8 => OK
[16302] OTA chunk @  c800, size: 1024, crc: 4b045b5f => OK
[16369] OTA chunk @  cc00, size: 1024, crc: 9cd3b7fc => OK
[16438] OTA chunk @  d000, size: 1024, crc: d7357ffb => OK
[16507] OTA chunk @  d400, size: 1024, crc: 5e9a4d25 => OK
[17572] OTA chunk @  d800, size: 1000, crc: dde66a84 => OK
[18597] CRC32 verified: db6d24fd
[18600] Applying the update

[104] Main firmware: 0.2.0
[107] Build: Aug 28 2023 17:35:43