search

JAremko / alpine-vim

"dockerized" Vim
264 stars 80 forks source link

reduce image size with multi-stage builds #5

Closed tuanhtrng closed 6 years ago

tuanhtrng commented 6 years ago

Got the image size down to 37MB from 184MB.

Tested on Debian Stretch, docker client 18.01.0-ce.

JAremko commented 6 years ago

@tuanhtrng That's great. Have you tested it with DockerHub builds?

JAremko commented 6 years ago

I tested multi stage build at DockerHub they seems to work fine.

I'll test your PR locally

JAremko commented 6 years ago

@tuanhtrng I tested it locally and tried to build the bundle out of it. But now I get errors like E484: Can't open file /tmp/build/share/vim/syntax/syntax.vim It looks like Vim must be built and used with the same --prefix so You'll have to rework your PR a bit.

tuanhtrng commented 6 years ago

A fix has been tested locally and pushed.

JAremko commented 6 years ago

@tuanhtrng Seems good to me. I cherry-picked it. Thanks :+1: