search

JBGruber / atrrr

AT Protocol (Authenticated Transfer Protocol behind Bluesky) R package
https://jbgruber.github.io/atrrr
Other
13 stars 2 forks source link

Prefer glue_data() when data might be list-ish, not an actual environment #18

Closed jennybc closed 1 month ago

jennybc commented 1 month ago

This PR is inspired by doing revdep checks for glue. The soon-to-be-released glue::glue() will error when .envir is not an actual environment. .envir has always been documented to be an environment and I've been working to make that actually true.

glue_data() does officially accept something "list-ish" as .x. So it is a better choice for your usage.

Backstory in glue:

https://github.com/tidyverse/glue/issues/308 https://github.com/tidyverse/glue/commit/e2b74ff17704261b5a7da25b4ebd2dec94740764 https://github.com/tidyverse/glue/issues/341

JBGruber commented 1 month ago

Thank you!

jennybc commented 1 month ago

glue 1.8.0 has been accepted on CRAN now.