search

JBKahn / flake8-debugger

flake8 debug statement checker
MIT License
41 stars 10 forks source link

Does not work anymore with flake8 3.0.0 - 3.2.0 #6

Closed JeanFred closed 7 years ago

JeanFred commented 8 years ago

With 

    flake8==2.6.2
    flake8-debugger==1.4.0

I do get violations:

./foo/bar/baz.py:272:3: T002 import for ipdb found as ipdb
./foo/bar/baz.py:273:3: T002 trace method for ipdb found as set_trace

With 

    flake8==3.0.4
    flake8-debugger==1.4.0

The violations are not raised.

JBKahn commented 7 years ago

I was on vacation at the time. I'll take a look in a few days. Thanks for letting me know.

mattayes commented 7 years ago

Any update?

JBKahn commented 7 years ago

Ohhh, interesting, this seems to be true of 3.0.x and 3.1.x and 3.2.x but works in 3.3.x

which is what I am using....I'll check the change log.

JBKahn commented 7 years ago

This is the same as https://github.com/JBKahn/flake8-print/pull/17

I'll take more of a look but unfortunately I don't want to merge a fix until I understand the ramifications. Maybe the changelog will enlighten me.

JBKahn commented 7 years ago

This was the fix that covered it https://gitlab.com/pycqa/flake8/issues/257

Given this was a bug in flake8, I think I'm going to keep this as is.

JeanFred commented 7 years ago

Nice − I can confirm that with 

flake8==3.2.1
flake8-debugger==1.4.0

violations are correctly reported.

Thanks for looking into this!