search

JBKahn / flake8-print

flake8
MIT License
121 stars 21 forks source link

Diversify codes; DRY the check #14

Closed mfalesni closed 8 years ago

JBKahn commented 8 years ago

Looks pretty good on my phone through vacation eyes. Away for the week but I'll take a look when I get back at what you have.

mfalesni commented 8 years ago

@JBKahn Thanks. The only functional difference is that I add a separate code for print function so I can enforce print functions in new code. Therefore I want to suppress the function issue and let the other two yell.

jayvdb commented 8 years ago

Code looks great. Could you squash the three commits into a single commit.

What does DRY the check" mean in the summary of the first commit? Is DRY an acronym?

mfalesni commented 8 years ago

Don't Repeat Yourself :) Yeah, once I get to the computer, I will.

mfalesni commented 8 years ago

@jayvdb Aaaand, it's done.

JBKahn commented 8 years ago

Can you make it T003 instead of 2 because I use that in my debugger checker?

mfalesni commented 8 years ago

Sure.

mfalesni commented 8 years ago

@JBKahn Done.

JBKahn commented 8 years ago

pushed, version 2.0.2 should be up on pipy now.

mfalesni commented 8 years ago

Thanks, I have already installed this plugin in my flaker.