JBKahn / flake8-print

flake8
MIT License
121 stars 21 forks source link

`noqa` comment does bring up new violations #40

Closed sobolevn closed 5 years ago

sobolevn commented 5 years ago

After updating to 3.1.3 I have new violations.

Let's start with the regular print usage:

print(1)

Output:

» flake8 ex.py

ex.py

  1:1      T001  print found.
  print(1)
  ^

Full list of violations and explanations:
https://wemake-python-stylegui.de/en/0.12.5/pages/usage/violations/

That's ok. Now, let's ignore this violation with a noqa comment:

print(1)  # noqa: T001

Output:

» flake8 ex.py

ex.py

  1:1      T002  Python 2.x reserved word print used.
  print(1)  # noqa: T001
  ^

Full list of violations and explanations:
https://wemake-python-stylegui.de/en/0.12.5/pages/usage/violations/

That's not what I expect to happen. I expect that after my noqa comment is created I will receive 0 violations. Moreover, I am not sure how comment can change print violation code.

This all happed somewhere at this point: https://github.com/wemake-services/wemake-python-styleguide/pull/964

With 3.1.1 everything works as it should.

JBKahn commented 5 years ago

Can you provide more information? Pip freeze for example? As the tests in the repository are passing

JBKahn commented 5 years ago

I think I know the fix but I need to make sure I can reproduce it so I can be sure I did

sobolevn commented 5 years ago

flake8:

» flake8 --bug-report
{
  "dependencies": [
    {
      "dependency": "entrypoints",
      "version": "0.3"
    }
  ],
  "platform": {
    "python_implementation": "CPython",
    "python_version": "3.7.4",
    "system": "Darwin"
  },
  "plugins": [
    {
      "is_local": false,
      "plugin": "flake8-annotations-complexity",
      "version": "0.0.2"
    },
    {
      "is_local": false,
      "plugin": "flake8-bandit",
      "version": "2.1.2"
    },
    {
      "is_local": false,
      "plugin": "flake8-broken-line",
      "version": "0.1.1"
    },
    {
      "is_local": false,
      "plugin": "flake8-bugbear",
      "version": "19.8.0"
    },
    {
      "is_local": false,
      "plugin": "flake8-comprehensions",
      "version": "3.0.1"
    },
    {
      "is_local": false,
      "plugin": "flake8-debugger",
      "version": "3.2.1"
    },
    {
      "is_local": false,
      "plugin": "flake8-docstrings",
      "version": "1.5.0, pydocstyle: 4.0.1"
    },
    {
      "is_local": false,
      "plugin": "flake8-eradicate",
      "version": "0.2.3"
    },
    {
      "is_local": false,
      "plugin": "flake8-executable",
      "version": "2.0.3"
    },
    {
      "is_local": false,
      "plugin": "flake8-print",
      "version": "3.1.3"
    },
    {
      "is_local": false,
      "plugin": "flake8-pytest",
      "version": "1.3"
    },
    {
      "is_local": false,
      "plugin": "flake8-return",
      "version": "0.1.3"
    },
    {
      "is_local": false,
      "plugin": "flake8-string-format",
      "version": "0.2.3"
    },
    {
      "is_local": false,
      "plugin": "flake8_builtins",
      "version": "1.4.1"
    },
    {
      "is_local": false,
      "plugin": "flake8_coding",
      "version": "1.3.2"
    },
    {
      "is_local": false,
      "plugin": "flake8_commas",
      "version": "2.0.0"
    },
    {
      "is_local": false,
      "plugin": "flake8_isort",
      "version": "2.3"
    },
    {
      "is_local": false,
      "plugin": "flake8_pep3101",
      "version": "1.2.1"
    },
    {
      "is_local": false,
      "plugin": "flake8_quotes",
      "version": "2.1.0"
    },
    {
      "is_local": false,
      "plugin": "logging-format",
      "version": "0.6.0"
    },
    {
      "is_local": false,
      "plugin": "mccabe",
      "version": "0.6.1"
    },
    {
      "is_local": false,
      "plugin": "naming",
      "version": "0.8.2"
    },
    {
      "is_local": false,
      "plugin": "nitpick",
      "version": "0.21.2"
    },
    {
      "is_local": false,
      "plugin": "pycodestyle",
      "version": "2.5.0"
    },
    {
      "is_local": false,
      "plugin": "pyflakes",
      "version": "2.1.1"
    },
    {
      "is_local": false,
      "plugin": "radon",
      "version": "2.4.0"
    },
    {
      "is_local": false,
      "plugin": "rst-docstrings",
      "version": "0.0.11"
    },
    {
      "is_local": false,
      "plugin": "wemake-python-styleguide",
      "version": "0.12.5"
    }
  ],
  "version": "3.7.9"
}

pip:

» pip --version
pip 19.0.3 from /Users/sobolev/Documents/github/wemake-python-styleguide/.venv/lib/python3.7/site-packages/pip (python 3.7)

python: Python 3.7.4

JBKahn commented 5 years ago

Thanks, fixed! 3.1.4 released.