search

JBKahn / flake8-print

flake8
MIT License
121 stars 21 forks source link

Inline #nopep8 comment has no effect with 3.1.3 #41

Closed LKay closed 5 years ago

LKay commented 5 years ago

This might be related to #40 but violation is different, so I'm making new issue.

Our builds on CI server started to fail just when 3.1.3 was released. Seems like inline # nopep8 comment has no effect anymore and on such line:

...
print(foo) # nopep8
...

results in violation error:

my_project/print_mailer.py:35:9: T001 print found.

It was just bump of patch part of semver so CI server fetched the most recent version and older version was present on my local machine. Took me a while to track down what was causing this, but everything seems to be working fine wit 3.1.1.

JBKahn commented 5 years ago

This package never explicitly supported that as I have no idea that comment existed. So I'll have to take a look. There are no tests for that behavior.

JBKahn commented 5 years ago

Also, same as my reply to the other one. Can you give me a pip freeze or something to help me recreate the issue.

JBKahn commented 5 years ago

3.1.4 released with support for that comment added.