inkcpp_test build error on M1/arm64

JBenda / inkcpp

Inkle Ink C++ Runtime with JSON>Binary Compiler

MIT License

73 stars 15 forks source link

inkcpp_test build error on M1/arm64 #37

Closed JBenda closed 2 years ago

JBenda commented 2 years ago

Update Catch dependency to fix compile error

brwarner commented 2 years ago

I think the fail is caused by some kind of permission issue. Let's see if it works when I re-trigger the jobs.

brwarner commented 2 years ago

This is a known GitHub issue when issuing PRs from a fork.

https://github.com/actions/first-interaction/issues/10

The failing action is trying to post a comment on this PR with the inkproof results but since it's running from a fork, the environment is read-only (despite the fact you're a collaborator on this project).

Anyway, the builds are passing so that's good.

JBenda commented 2 years ago

Then we just need to verify that this fixes the compilation error for M1/arm64 chips.

JBenda commented 2 years ago

Update Catch to work on M1/arm64
fix Warning from macOS compiler about wrong initialization order
disable "Pull Request Report" for PRs from forks