search

JBenda / inkcpp

Inkle Ink C++ Runtime with JSON>Binary Compiler
MIT License
73 stars 15 forks source link

Fix compilation with C++17 #90

Closed MrHands closed 1 month ago

MrHands commented 1 month ago

I'm integrating your project into my game, and unfortunately, it's stuck on C++17 for a bit longer. I found that compilation fails on the list header because named parameters are a C++20 feature. However, this is the only place in the codebase that explicitly uses a C++20 feature, so I felt it justified to downgrade it to C++17 for now. I want to upgrade my game to C++20 soon, so feel free to reject this PR if it doesn't align with your vision for the project. I also found a compile warning related to an implicit cast to ink::size_t in the string implementation when using STL, so I fixed that and prettied-up the whitespace.

JBenda commented 1 month ago

This is a good point. Iff at any point the resolution code uses concept's we can go back to C++20.

Thanks for spotting the size_t thing.

Good luck with your project, if you need ink related help there is the inkle Discord https://discord.gg/inkle.

If you find more feel free to open more PRs.