search

JBirdVegas / external_jbirdvegas_mGerrit

mGerrit is a Gerrit instance viewer
19 stars 8 forks source link

Clean up library dependencies #31

Closed JBirdVegas closed 8 years ago

JBirdVegas commented 9 years ago

Biggest change is to add support-annotations and prefer them over jetbrains annotations which we still use for @Contract

Get jetbrains annotations, android support annotations and android support library v4 from repositories.

Remove now unused jars from libs/

Seems we are using analytics v2 which is @Deprecated. Once the change is made to use v3 then we can get analytic jar from repositories as well.

JBirdVegas commented 9 years ago

@p4r4n01d Here is a reference for the android support annotations. http://tools.android.com/tech-docs/support-annotations

Should give us more control in specifying inputs if we want.

p4r4n01d commented 9 years ago

Do make sure that the rotating issue is not present. Last time I tried to update support libraries, rotating the device made the app crash. That was crashing on both phones and tablets (nexus 4 and rk30).

Side note: you seemed to inadvertently mention other github users in your original comment.

JBirdVegas commented 9 years ago

Oops updated comment. I'll test for a rotation crash later today. If its still there we can drill down or revert the updated version

JBirdVegas commented 8 years ago

This is redundant now... closing