search

JBirdVegas / external_jbirdvegas_mGerrit

mGerrit is a Gerrit instance viewer
19 stars 8 forks source link

Remove local copy of jar libraries #39

Closed est31 closed 8 years ago

est31 commented 8 years ago

Use their maven versions instead.

p4r4n01d commented 8 years ago

Sorry for the late reply, I have been busy working on the next feature. I have updated the Gerrit API library (available here: https://github.com/p4r4n01d/gerrit-rest-java-client/tree/httpclient-android), fixed an old bug around starring changes and packaged into a jar with maven (local install). This automatically ensures all the tests pass (not sure why the bug wasn't picked up). I am happy to merge this, however I don't want to take the changes to the Gerrit API library. I am going to leave it as an included jar due to the problems mentioned above with Apache and so Android-specific bugfixes can be included without impacting the main non-Android branch. I can include this in the next release, along with a number of other bugfixes and the refine search feature.

est31 commented 8 years ago

Okay, see #42