JBirdVegas / external_jbirdvegas_mGerrit

mGerrit is a Gerrit instance viewer
19 stars 8 forks source link

Add to F-Droid #40

Closed pizzamaker closed 8 years ago

pizzamaker commented 8 years ago

There's a thread for its inclusion at: https://f-droid.org/forums/topic/mgerrit/

JBirdVegas commented 8 years ago

Your welcome to submit a pull request. I have no objection to F-Droid's inclusion

pizzamaker commented 8 years ago

Adding packages to F-Droid is generally done by sending a pull request at https://gitlab.com/fdroid/fdroiddata

You need to install f-droid server and data locally, create a metadata file like one of these https://gitlab.com/fdroid/fdroiddata/tree/master/metadata and see if your local f-droid server can build mGerrit. If it does, you commit your changes and send a pull request.

ghost commented 8 years ago

Already available here with a mention "Usage of GA has been removed from this build." PR #39 is not related with its inclusion?

pizzamaker commented 8 years ago

Oh you're right! It's been added. Thanks, closing this issue.

JBirdVegas commented 8 years ago

Thanks @M2ck... I'm glad they removed the GA so it doesn't conflict with the GP stats, but it would be nice to know how many are downloading from F-Droid out of curiosity.

Looking at the diff from the metadata I like some of the gradle changes. May pull them into the main stream. Also might look at adding a productFlavor that doesn't include GA tracking if that's something people want.