JBirdVegas / external_jbirdvegas_mGerrit

mGerrit is a Gerrit instance viewer
19 stars 8 forks source link

Improve F-Droid support #49

Closed ghost closed 5 years ago

ghost commented 8 years ago

mGerrit F-Droid version: 2.111.72

mGerrit Google Play version: 2.111.80

JBirdVegas commented 8 years ago

Totally cool with F-Droid hosting the app but they are removing the the analytics. We can't make them apply their patches faster. Maybe we can make a productFlavor with the analytics turned off then they should be able to build right from source. I'll look into this as an approach from our side to encourage updating but unless I'm misunderstanding what @f-droid is doing it's on them to update to the latest correct?

p4r4n01d commented 8 years ago

Agreed. I am happy to help any build customization for F-Droid hosting (such as a config which disables analytics) but am going to stop short of actually building and releasing to F-Droid.

est31 commented 8 years ago

Hi again! I've prepared the 2.111.84 version for the f-droid build and the flavors patch really helped. I now don't have to touch any java code anymore. There still are some changes I did in my patch:

I'll provide a PR for the last change for the case you'd like to have it in upstream as well. It makes sense as its very nice towards the repo size.

p4r4n01d commented 8 years ago

Glad to hear that @est31! Of the changes you mentioned I am most interested in the first two points as these may be able to fix Travis and/or the release build server (jenkins), which would be great and speed up the release process.

For 'Remove the fabric dependency from the repo list': If you can find a way to have this working for both flavours, submit a PR so it can be merged into master.

I'll have a look at #57, but will need a lot of testing to make sure nothing is broken.

est31 commented 8 years ago

Hmm, I'll do a PR with the first two points then.

nailyk-fr commented 7 years ago

I just ask on f-droid and told me mGerrit can't be build because of proprietary parts. Should I open a new issue or is it on the way?

Thanks