search

JBirdVegas / external_jbirdvegas_mGerrit

mGerrit is a Gerrit instance viewer
19 stars 8 forks source link

Improve UI #54

Closed ghost closed 5 years ago

ghost commented 8 years ago

For match with Material Design guidelines, I suggest to move all options from action bar, except Search feature, into the navigation drawer. See screenshots below for see what I expect. By the way, maybe it's not your priority but I've found this tool ([Tool] Android Material Icon Generator) to quickly create a Material icon launcher, it's free and open source!

Action bar screenshot_2016-03-16-22-23-03 Navigation drawer screenshot_2016-03-16-22-23-11

JBirdVegas commented 8 years ago

Looks good. Another design change I was contemplating was moving the navigation {Review | Merged | Abandoned} to the new bottom navigation style. https://www.google.com/design/spec/components/bottom-navigation.html#

ghost commented 8 years ago

Indeed now that the bottom bar is officially a Material Design's component, it would be nice to play with it!

p4r4n01d commented 8 years ago

I am happy moving the Gerrit Switcher into the navigation bar and that is something I can do really quickly. Your screenshot doesn't specify where the Gerrit quick-switch options should go (if you have previously viewed data for another Gerrit instance it will appear after the projects list as AICP does in the following screenshot. I am not sure how settings would fit into this. Either:

a) Have settings separated on its own above the Gerrit quick-switch options. This would look odd IMO b) Have settings stuck to the bottom (a bit like the navigation drawer on ES File Explorer). c) Settings option at the bottom of the list but not stuck to the bottom. Ruling this out as the quick-switch options are dynamic.

content---com google android apps gsa velvet extradex extradexhostprovider-assist com google android apps gsa assist screenshotprovider-com google android apps gsa assist screenshotprovider-screenassistscreenshots-screenshot_201603

Also refresh and help are other options in the menu, where should these go. Refresh doesn't really belong in the navigation bar. I don't think help really does either as it opens a dialog. content---com google android apps gsa velvet extradex extradexhostprovider-assist com google android apps gsa assist screenshotprovider-com google android apps gsa assist screenshotprovider-screenassistscreenshots-screenshot_20 1

Sorry but I am going to veto any attempts to move the change status filters from tabs to a bottom navigation bar. Even though it is officially specified in the design guidelines I still believe it looks ugly. Also note that these aren't normally used in combination with a viewpager (tab swiping).

I am prepared to go back to tabs fixed to the toolbar and do some scrolling trickery with them such as what is described here: https://medium.com/@dan1ve/android-howto-material-design-tabs-scrolling-like-in-google-play-music-12273ce07bc with the google play music app

ghost commented 8 years ago

About Projet list and previously Gerrit instance viewed, what do you think to use an arrow which is expanded/reduced when you press it like in Solid Explorer, screenshot below:

unnamed

Help button could be under Settings button and for Refresh button I'm not sure of its utility because swipe-to-refresh feature is already implemented so I think that this button is redundant and useless.

p4r4n01d commented 8 years ago

The refresh option and swipe-to-refresh do different things. The refresh option loads data for all three tabs at once and is a workaround for the server version not updating.

ghost commented 8 years ago

My bad I didn't know it!