search

JBirdVegas / external_jbirdvegas_mGerrit

mGerrit is a Gerrit instance viewer
19 stars 8 forks source link

Allow to build on machines with old gradle and less RAM #58

Closed est31 closed 8 years ago

est31 commented 8 years ago

See #49.

p4r4n01d commented 8 years ago

Sorry est31, but this make compilation of all builds slower for those running the latest AS and plenty of RAM, thereby slowing down my development time. Thanks for submitting this though as it has identified one problem with Travis to address (should not try to build multiple flavours). When you first mentioned this change, I wasn't clear on what was involved and didn't realise that it would affect those on newer versions of gradle.

We are trying to keep the gradle version inline with the latest stable so will not be downgrading to an older version when we don't have to.

I am going to close this PR as there is nothing here I am willing to merge. If you come up with something that doesn't negatively impact those with the 'latest and greatest' (so to speak) I'll be happy to have a look at it.

est31 commented 8 years ago

Okay, fine.

est31 commented 8 years ago

Note: if you want to just fix travis, you might try to edit travisBuilder.sh to use ./gradlew instead of gradle.