search

JBirdVegas / external_jbirdvegas_mGerrit

mGerrit is a Gerrit instance viewer
19 stars 8 forks source link

Reset file directory structure to match android plugin defaults #7

Closed JBirdVegas closed 9 years ago

JBirdVegas commented 9 years ago

This moves the following resources ./src -> ./src/main/java ./res -> ./src/main/res ./AndroidManifest.xml -> ./src/main/AndroidManifest.xml

This removes the need to declare non default locations in the build.gradle

This breaks the ant builds. Tried a few things to fix the ant looking in the wrong place for the AndroidManifest.xml, either I'm declaring the values wrong or they are overridden somewhere.

JBirdVegas commented 9 years ago

@p4r4n01d do yo have a preference on the directory structure? The basic idea was to match AS standard directories.

p4r4n01d commented 9 years ago

My only preference is to get this working: https://developer.android.com/sdk/installing/studio-androidview.html. There is also some more documentation here: http://developer.android.com/tools/studio/index.html#project-structure. I am guessing this is what you mean with AS standard directories though.

p4r4n01d commented 9 years ago

Also, can you organise activities and fragments into folders. FragmentActivities can go in a activity folder and fragments can go in a fragments folder.

JBirdVegas commented 9 years ago

The Android view appears to be loading as expected now. Also organized the Fragments and Activities now the only class at the root package level is TheApplication. Only problem right now is the tests are not running. The android plugin added unit tests to the build recently [1] and since I've had to get it working for work I thought I might add some unit tests for us. But sadly its not running during the test or check phases of the build. I'll investigate why but I don't think unit tests should stop the merge. We haven't ever had test before.

[1] http://tools.android.com/tech-docs/unit-testing-support

JBirdVegas commented 9 years ago

@p4r4n01d If I merge this now will it mess with your auth work? This can wait if needed

p4r4n01d commented 9 years ago

My auth work will take a bit longer, so merge this if you have tested that it works and I'll merge it (read: merge master) into my branch. I'll worry about any problems then. On 16 Mar 2015 5:42 pm, "Jon Stanford" notifications@github.com wrote:

@p4r4n01d https://github.com/p4r4n01d If I merge this now will it mess with your auth work? This can wait if needed

— Reply to this email directly or view it on GitHub https://github.com/JBirdVegas/external_jbirdvegas_mGerrit/pull/7#issuecomment-81449465 .