search

JBirdVegas / external_jbirdvegas_mGerrit

mGerrit is a Gerrit instance viewer
19 stars 8 forks source link

Save the name of the current Gerrit name in the preferences. #9

Closed p4r4n01d closed 9 years ago

p4r4n01d commented 9 years ago

Keep track of the name of the current Gerrit in the shared preferences. Will update the name if it was not previously saved (for those updating mGerrit).

Change-Id: I3f4b8c93f335ad081c142cc2d157165934ce782d

p4r4n01d commented 9 years ago

This is not used ATM, but will be used for auth. I was doing the layout and realised we don't use the name of the current Gerrit anywhere but the Gerrit switcher.

Re. the comment in GerritControllerActivity: Ideally we should have a check that the current Gerrit has a name saved against it. The Gerrit switcher probably would previously have broken before. We could just show a dialog box asking the user for its name if we did not have one and save that. I don't think that this parameter is being used though so I am not too worried.

JBirdVegas commented 9 years ago

Works for me. Really anything to get auth :dancers: