JCMais / node-libcurl

libcurl bindings for Node.js
https://npmjs.org/package/node-libcurl
MIT License
666 stars 118 forks source link

chore: add 'files' field to package.json #398

Closed nktnet1 closed 8 months ago

nktnet1 commented 1 year ago

Hello,

In version 3.0.0, the code tab on npm contains many redundant files:

node-libcurl-3 0 0

From what I can see, only

  "files": [
    "binding.gyp",
    "dist",
    "scripts",
    "src"
  ],

is necessary to install node-libcurl.

For example, I made a fork of node-libcurl called easy-libcurl@1.0.3 containing the "files" attribute above:

easy-libcurl@1.0.3

which installs and runs fine. While easy-libcurl only exports the Easy interface, I doubt this will have an effect on which files are necessary for the distributable.

This change will reduce the package size when installed. Hope it helps in some way :).

Thank you again for your work on node-libcurl!