JCSDA-internal / ioda-converters

Various converters for getting obs data in and out of IODA
9 stars 4 forks source link

Change Ozone Variable Name and Turn on Error #1323

Closed danholdaway closed 1 year ago

danholdaway commented 1 year ago

Description

Some small fixes needed for current GMAO testing.

Issue(s) addressed

N/A

Dependencies

N/A

Impact

N/A

Checklist

karpob commented 1 year ago

To match the new convention you'll also need to change ozoneLayer to ozoneTotal in the If statement

BenjaminRuston commented 1 year ago

seeing two failed tests:

iodaconv_gsi_ncdiag_coding_norms
test_iodaconv_gsidiag_rad

--

test_iodaconv_gsidiag_rad

PatNichols commented 1 year ago

@danholdaway do you need to update the output file?

BenjaminRuston commented 1 year ago

update of testOutput likely needed

danholdaway commented 1 year ago

OK thanks. I will take a look.

karpob commented 1 year ago

@danholdaway I think you might need to indent twice for that "if" line continuation coding norm error.

danholdaway commented 1 year ago

I think it's ready now. Thanks all.

gmao-jjin3 commented 1 year ago

@PatNichols @BenjaminRuston I think this one needs to be merged ASAP, so that we check it out and re-create our data.

BenjaminRuston commented 1 year ago

@gthompsnJCSDA think this is all set

BenjaminRuston commented 1 year ago

@jeromebarre just FYI, note this was merged please let us know if you see anything that may need attention