search

JCSDA-internal / ioda-converters

Various converters for getting obs data in and out of IODA
9 stars 4 forks source link

Add aircraft bias converter #1356

Closed kevindougherty-noaa closed 12 months ago

kevindougherty-noaa commented 1 year ago

Description

The following scripts compile successfully and create an output aircraft bias .nc4 file with information about the existing predictors and tail ids.

Issue(s) addressed

Resolves #804

CoryMartin-NOAA commented 1 year ago

Thanks @kevindougherty-noaa this is a good start, can you start to look at the changes I have here: https://github.com/JCSDA-internal/ioda-converters/compare/feature/refactor_satbias and use the new file format structure? I can help with doing this if needed.

Also check the coding norms!

PatNichols commented 1 year ago

@kevindougherty-noaa not sure if you can see it but you are only failing coding norms

kevindougherty-noaa commented 1 year ago

Newest commit changes for the converter compiles but when testing, it throws a segmentation fault with no other indication of why.

Edit: I also updated yaml to work with changes appropriately, but did not include in commit.

CoryMartin-NOAA commented 1 year ago

This is getting close, I think the remainder is just some tidying up, marking as ready for review for discussion. Main question remaining is what to do with the datetimes. Should those be IODA datetime objects or integer values, etc.

CoryMartin-NOAA commented 1 year ago

Note the base branch is not the sprint branch but my satbias refactoring branch, this is just to see the changes made here and not both. This branch should be merged in after that in #1360

BenjaminRuston commented 1 year ago

great thanks everyone for the input this looks good to go correct, will likely wait for the morning but I'm doubling down on approval this seems ready

huishao-r commented 12 months ago

@kevindougherty-noaa It shows there are conflicts that must be resolved. Would you please take a look: Conflicting files src/varbc_gsi/SatBiasConverter.cpp src/varbc_gsi/satbias_upgrader.py

CoryMartin-NOAA commented 12 months ago

@huishao-r I think that's because I just pushed to the other branch. Let me resolve.

BenjaminRuston commented 12 months ago

@CoryMartin-NOAA I'm going ahead to test this again, and then will merge into your branch

also that branch also seems ready to go

BenjaminRuston commented 12 months ago

an ncdump of a resulting file produces this for nvars:

 nvars = 0 ;
BenjaminRuston commented 12 months ago

in the bias coefficient section do we need to differentiate the variables for aircraft even though it is just a single variable of temperature

aircraftVerticalVelocity
CoryMartin-NOAA commented 12 months ago

@BenjaminRuston we probably would want: variables(nvars) = [airTemperature where nvars=1

In your above example, is that nvars the dimension or the variable that is 0?