JCSDA-internal / ioda-converters

Various converters for getting obs data in and out of IODA
9 stars 4 forks source link

satellite bias coefficient conversion update including upgrader #1360

Closed BenjaminRuston closed 12 months ago

BenjaminRuston commented 1 year ago

Description

provide updates to the satellite bias correction converter as well as an upgrade capability for existing files

BenjaminRuston commented 1 year ago

passed all the ctests:

  Test  #15: iodaconv_satbias_py_coding_norms
  Test  #16: iodaconv_satbias_coding_norms
  Test  #67: test_iodaconv_satbias_viirs_aod
  Test #139: test_iodaconv_satbias_amsua
  Test #140: test_iodaconv_satbias_cris
  Test #141: test_iodaconv_satbias_gmi
  Test #142: test_iodaconv_satbias_ssmis

locally would like to try on a few more files in the morning and discuss but overall seems like this too is ready

BenjaminRuston commented 1 year ago

tested on a couple bias files atms_n20 and iasi_mtb and all is working fine

BenjaminRuston commented 12 months ago

thanks @CoryMartin-NOAA testing again after merge of Kevin's PR

BenjaminRuston commented 12 months ago

this is working for me @CoryMartin-NOAA please merge if you're ready or let me know something you'd like me to test. I can't approve my PR

CoryMartin-NOAA commented 12 months ago

I'd like @ADCollard to give it a quick once-over but then I'm happy to merge it in.

ADCollard commented 12 months ago

The ctests all pass for me and I am happy with the changes. I checked the radiance and aircraft output files and the contents appear as expected.