Bugfix/mcmodel fix - Githubissues

JCSDA-internal / ioda-converters

Various converters for getting obs data in and out of IODA

9 stars 4 forks source link

Bugfix/mcmodel fix #1368

Closed PatNichols closed 12 months ago

PatNichols commented 12 months ago

Description

This fixes a linking errror when someone uses the gcc c++ compiler on a mac.

Issue(s) addressed

Resolves #1366

Dependencies

None

Impact

None

Checklist

[x ] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[x ] I have run the unit tests before creating the PR

PatNichols commented 12 months ago

@rmclaren could you see if this works for you? Thanks!

rmclaren commented 12 months ago

@PatNichols OK that is working much better for me. I think its technically possible for someone with a Mac to use the Intel compiler as well (though I don't run it this way)... I'm uncertain if we need to support this or not... Especially since all the Macs are moving to ARM based processors anyways.

srherbener commented 12 months ago

Just want to point out that since Apple decided to move to the ARM based processors (M1 and M2), Intel has dropped support for their compiler on Mac M1 and M2 moving forward. Intel will still, for a while, support oneAPI on Intel based Macs but that will eventually get phased out.

It is correct that you can emulate Intel on Mac M1 and M2, using the Rosetta application. But Intel is not supporting this, and we have also decided for JEDI to not support Rosetta. I think it's safe to not worry about Intel on the Mac.

rmclaren commented 12 months ago

Sounds good.

PatNichols commented 12 months ago

@rmclaren Thanks. If you good approve it we can get this merged.