search

JCSDA-internal / ioda-converters

Various converters for getting obs data in and out of IODA
9 stars 2 forks source link

Set minimum version for NCEPLIB-bufr #1381

Closed rmclaren closed 10 months ago

rmclaren commented 11 months ago

Description

Sets the minimum required version for NCEPLIB_bufr to 12.0.0.

Issue(s) addressed

1380

CoryMartin-NOAA commented 11 months ago

@rmclaren will this mean that your BUFR code now won't build on NOAA HPC without spack-stack 1.5.0 even with this change?

rmclaren commented 11 months ago

@CoryMartin-NOAA Should build, but won't include BUFR code if relevant version of NCEPLIB-bufr is not found...

rmclaren commented 11 months ago

Can anyone see why builds are failing... I don't have permissions to see whats going on...

rmclaren commented 11 months ago

Nevermind. Figured it out...

danholdaway commented 11 months ago

Nevermind. Figured it out...

Sorry I led you astray with the MINIMUM_VERSION thing.

I'm fine with merging this instead of merging the revert PR. But I will leave it up to EMC who might want to still run the BUFR converters without going to spack 1.5

fcvdb commented 11 months ago

I tried to build the IODA bundle on Orion with spack-stack 1.4.0 (bufr/11.7.1) and the ecbuild configuration failed with this error message:

CMake Error at /work/noaa/epic-ps/role-epic/spack-stack/spack-stack-1.4.0/envs/unified-env-v2/install/gcc/10.2.0/ecbuild-3.7.2-ptjxnc5/share/ecbuild/cmake/ecbuild_add_executable.cmake:248 (target_link_libraries):
  Target "print_queries.x" links to:
    bufr::bufr_4
  but the target was not found.
rmclaren commented 11 months ago

Shoot, I'll take a look.

rmclaren commented 11 months ago

@fcvdb Latest checkin should fix this problem.

PatNichols commented 11 months ago

Has this been tested with an environment that does not have version 12.0.0? Make sure all the code sections and tests are shut off when the proper versions of bufr is not availeable.

Thanks!

@srherbener I am testing on aws. There are some bugs in our cmake that are now apparent. There is one test that runs that shouldn't and some others I am looking at. There are 2 ways to tests. Use spack-stack-1.5 but unload the bufr module or use spack-stack-1.4.0. I uses the former though the latter might be closer to what users are doing.

PatNichols commented 10 months ago

@fcvdb did this pass on Orion?