Closed rmclaren closed 10 months ago
@rmclaren will this mean that your BUFR code now won't build on NOAA HPC without spack-stack 1.5.0 even with this change?
@CoryMartin-NOAA Should build, but won't include BUFR code if relevant version of NCEPLIB-bufr is not found...
Can anyone see why builds are failing... I don't have permissions to see whats going on...
Nevermind. Figured it out...
Nevermind. Figured it out...
Sorry I led you astray with the MINIMUM_VERSION thing.
I'm fine with merging this instead of merging the revert PR. But I will leave it up to EMC who might want to still run the BUFR converters without going to spack 1.5
I tried to build the IODA bundle on Orion with spack-stack 1.4.0
(bufr/11.7.1) and the ecbuild
configuration failed with this error message:
CMake Error at /work/noaa/epic-ps/role-epic/spack-stack/spack-stack-1.4.0/envs/unified-env-v2/install/gcc/10.2.0/ecbuild-3.7.2-ptjxnc5/share/ecbuild/cmake/ecbuild_add_executable.cmake:248 (target_link_libraries):
Target "print_queries.x" links to:
bufr::bufr_4
but the target was not found.
Shoot, I'll take a look.
@fcvdb Latest checkin should fix this problem.
Has this been tested with an environment that does not have version 12.0.0? Make sure all the code sections and tests are shut off when the proper versions of bufr is not availeable.
Thanks!
@srherbener I am testing on aws. There are some bugs in our cmake that are now apparent. There is one test that runs that shouldn't and some others I am looking at. There are 2 ways to tests. Use spack-stack-1.5 but unload the bufr module or use spack-stack-1.4.0. I uses the former though the latter might be closer to what users are doing.
@fcvdb did this pass on Orion?
Description
Sets the minimum required version for NCEPLIB_bufr to 12.0.0.
Issue(s) addressed
1380