relocate converter scripts that use the python api to ncep bufrlib

JCSDA-internal / ioda-converters

Various converters for getting obs data in and out of IODA

9 stars 2 forks source link

relocate converter scripts that use the python api to ncep bufrlib #1396

Closed BenjaminRuston closed 10 months ago

BenjaminRuston commented 10 months ago

Description

there are some python converter scripts that lived in testinput put into the src directory

Issue(s) addressed

Resolves #1316

Checklist

[ ] I have performed a self-review of my own code

BenjaminRuston commented 10 months ago

@emilyhcliu here's the converters relocated, PEP8 enforced and common calling structure

was thinking to add the snocvr converter too https://github.com/JCSDA-internal/ioda-converters/issues/1273 @YoulongXia-NOAA is helping, we need to finalize a ctest for this converter (awaiting update to NCEP BUFR input file) but we can start looking at the data now

fcvdb commented 10 months ago

Merging PR ufo #1397 introduced serious conflicts with this PR. I tried to resolve them manually.

BenjaminRuston commented 10 months ago

@rmclaren and/or @CoryMartin-NOAA yes, @srherbener I intentionally didn't move these yet.... but maybe iodaconv/src/test ?

test/tesetinput/bufr_query_fieldname_validation.py
test/tesetinput/bufr_query_python_test.py
test/tesetinput/bufr_query_python_to_ioda_test.py

BenjaminRuston commented 10 months ago

and move the bufr API testing functions in a subsequent PR?

but yes they were intentionally left where they were as they didn't explictly test conversion of a datatype

srherbener commented 10 months ago

@BenjaminRuston thanks for responding to my question, and I'm fine with doing this move in stages. Would the scripts that haven't been moved yet serve as tutorial examples (src/bufr/examples)?