This PR fixes ctests that exhibited overflow errors when handling int64 fill values. The typical way this shows up is when converting the date time values in the time offset format (float32) into date time values in the epoch format (int64).
This involves an update of test reference files for three tests:
test_iodaconv_prepbufr_ncep_api_adpsfc2ioda
test_iodaconv_prepbufr_ncep_api_sfcshp2ioda
test_iodaconv_bufr_ncep_prepbufr_adpupa_api
I verified that the only thing that changed in the test reference files was the values of the fill values used for dateTime and releaseTime variables (which are stored in the epoch format in int64 data type). Also verified that the fill value spec in the test reference files for dateTime and releaseTime are consistent with the actual values in the variable data (so the ioda reader will be able to recognize these as missing).
Issue(s) addressed
Partially addresses #1378
Dependencies
List the other PRs that this PR is dependent on:
None
Impact
Expected impact on downstream repositories:
The only impact is for cases where the actual value of missing values in dateTime and releaseTime matter. The expectation is that this means no impact.
Checklist
[x] I have performed a self-review of my own code
[x] I have made corresponding changes to the documentation (code comments)
[x] I have run the unit tests before creating the PR
[x] Test on HPC platform - Orion, GNU, OpenMPI
Note that differences between Orion and the Mac M1 were what triggered looking into this, so it would be good to verify that both of these get the same results.
Description
This PR fixes ctests that exhibited overflow errors when handling int64 fill values. The typical way this shows up is when converting the date time values in the time offset format (float32) into date time values in the epoch format (int64).
This involves an update of test reference files for three tests:
I verified that the only thing that changed in the test reference files was the values of the fill values used for dateTime and releaseTime variables (which are stored in the epoch format in int64 data type). Also verified that the fill value spec in the test reference files for dateTime and releaseTime are consistent with the actual values in the variable data (so the ioda reader will be able to recognize these as missing).
Issue(s) addressed
Partially addresses #1378
Dependencies
List the other PRs that this PR is dependent on: None
Impact
Expected impact on downstream repositories: The only impact is for cases where the actual value of missing values in dateTime and releaseTime matter. The expectation is that this means no impact.
Checklist
Note that differences between Orion and the Mac M1 were what triggered looking into this, so it would be good to verify that both of these get the same results.