JCSDA-internal / ioda-converters

Various converters for getting obs data in and out of IODA
9 stars 2 forks source link

Add a new variable for the wigosid to the bufr2ioda code(s) #1406

Closed PraveenKumar-NOAA closed 10 months ago

PraveenKumar-NOAA commented 10 months ago

Description

This PR adds a new Wigos variable like dateTime to the bufr2ioda code.

The following files are new:

The following files have been changed to add the functionality:

The wigos variable is look like this: WGOSIDS-WGOSISID-WGOSISNM-WGOSLID, e.g. 0-20000-0-71941

where the naming convention is stationWIGOSId (already exist in the ObsSpace.yaml).

The ioda-validate.x is also ran over the output NetCDF file and the results are: Final results: errors: 0 warnings: 0

Issue(s) addressed

The following issue is addressed: #1402

Dependencies

bufr2ioda and feature/query_new_result branch of the ioda-converters

Impact

None

Checklist

YoulongXia-NOAA commented 10 months ago

@PraveenKumar-NOAA, as WIGOS ID is different from dateTime (dateTime is no missing), the wigos ID has missing values. If any part of the four component is missing, it may lead to a string like as ---20000-0-71941, 0----0-71941, etc. Now I know that we can replace WGOSLID with LSTN (station local name) if it is missing. However, if the others such as WGOSIDS, WGOSISID, WGOSISN are missing, what values or string can be used to replace. This still needs to consider. This needs @BenjaminRuston and @emilyhcliu to give further guidances.

YoulongXia-NOAA commented 10 months ago

LSTN always exists without any missing. This is a good alternative.

PraveenKumar-NOAA commented 10 months ago

LSTN always exists without any missing. This is a good alternative.

@YoulongXia-NOAA I think most of the time WIGOSIDs are missing and decoders team need to ingest them. I am looking at my adpsfc file, which I have chosen for the unit test and there is no LSTN. There are also other mnemonics like RPID, SID, etc and I don't know which one we can use to replace WGOSLID.

srherbener commented 10 months ago

@PraveenKumar-NOAA is this PR superseded by #1407? If so, please close this one. Thanks!