ncdiag radiance bias addition to ioda output

JCSDA-internal / ioda-converters

Various converters for getting obs data in and out of IODA

9 stars 2 forks source link

ncdiag radiance bias addition to ioda output #1411

Closed BenjaminRuston closed 9 months ago

BenjaminRuston commented 9 months ago

Description

This adds the GsiBc to the IODA output from ncDiag

Issue(s) addressed

Resolves #1410

Checklist

[x] I have performed a self-review of my own code
[x] I have run the unit tests before creating the PR

danholdaway commented 9 months ago

Thanks for flagging this @BenjaminRuston. I have the corresponding change on the Swell side so from my perspective feel free to merge when ready. Does this replace the way we currently produce the bias correction coeffs using the text files from GSI?

CoryMartin-NOAA commented 9 months ago

@danholdaway I'm under the impression this is the bias itself and not the coeffs, which would still be the other converters (which are changing as part of the VarBC generalization)

danholdaway commented 9 months ago

OK, thanks @CoryMartin-NOAA. Will the generalization changes be backward compatible?

CoryMartin-NOAA commented 9 months ago

@danholdaway no but there will be an upgrader