JCSDA-internal / ioda-converters

Various converters for getting obs data in and out of IODA
9 stars 2 forks source link

a few of the BUFR API ctests failing with latest spack stack and bufrlib #1418

Closed BenjaminRuston closed 9 months ago

BenjaminRuston commented 9 months ago

Description

there are 4 ctests now failing in CI locally on my mac (spack-stack v1.5.1) and on Orion (also v1.5.1)

these should be using bufrlib 12.0.1

The following tests FAILED:
    105 - test_iodaconv_prepbufr_ncep_aircftprofiles2ioda (Failed)
    118 - test_iodaconv_bufr_ncep_prepbufr_adpupa_api (Failed)
    128 - test_iodaconv_bufr_ncep_rtma_aircft (Failed)
    129 - test_iodaconv_bufr_ncep_rtma_aircft_NC004103 (Failed)

Acceptance Criteria (Definition of Done)

the ctests above begin to pass again

BenjaminRuston commented 9 months ago

@rmclaren and @srherbener am able to reproduce these but not sure where the issue lies please advise

rmclaren commented 9 months ago

Could you run one of those ctests with the -V option to see the verbose output? ctest -V -R test_iodaconv_bufr_ncep_prepbufr_adpupa_api

BenjaminRuston commented 9 months ago

@rmclaren of course here you go: test_iodaconv_bufr_ncep_prepbufr_adpupa_api.txt test_iodaconv_bufr_ncep_rtma_aircft_NC004103.txt test_iodaconv_bufr_ncep_rtma_aircft.txt test_iodaconv_prepbufr_ncep_aircftprofiles2ioda.txt

BenjaminRuston commented 9 months ago

this has been reproducing on Orion as well with spack stack v1.5.1 that uses BUFRlib 12.0.1: https://spack-stack.readthedocs.io/en/1.5.1/PreConfiguredSites.html#msu-orion

the above output though is locally from my Mac M1

BenjaminRuston commented 9 months ago

the reproduction on Orion was reported by @srherbener I just also verified this on Orion and did get the same 4 ctests failing. This was using Intel, building the ioda-bundle with this setup: /work2/noaa/jcsda/bruston/work/JCSDA/JEDI/setup_jedi_intel.sh

BenjaminRuston commented 9 months ago

this addresses 3 of the 4 tests with the other being investigated further: https://github.com/JCSDA-internal/ioda-converters/pull/1419