JCSDA-internal / ioda-converters

Various converters for getting obs data in and out of IODA
9 stars 2 forks source link

Adding an IODA converter for balloon sonde data in JSON #1425

Closed smaticka closed 8 months ago

smaticka commented 8 months ago

Description

A python ioda converter is needed to convert the raw data from WindBorne Systems JSON format into IODA format. First for testing to see the quality of data and then to be able to use in near-real time Skylab operations.

Issue(s) addressed

Resolves #1424

Checklist

BenjaminRuston commented 8 months ago

@smaticka do you know how to fix these:

checking ./balloon_sonde_json2ioda.py
./balloon_sonde_json2ioda.py:177:9: E722 do not use bare 'except'
./balloon_sonde_json2ioda.py:179:101: E261 at least two spaces before inline comment
./balloon_sonde_json2ioda.py:180:13: E722 do not use bare 'except'
./balloon_sonde_json2ioda.py:181:21: E261 at least two spaces before inline comment
./balloon_sonde_json2ioda.py:181:47: W291 trailing whitespace
./balloon_sonde_json2ioda.py:182:1: W293 blank line contains whitespace
./balloon_sonde_json2ioda.py:186:9: E722 do not use bare 'except'
./balloon_sonde_json2ioda.py:188:112: E261 at least two spaces before inline comment
./balloon_sonde_json2ioda.py:189:13: E722 do not use bare 'except'
./balloon_sonde_json2ioda.py:190:21: E261 at least two spaces before inline comment

a simple thing to use is to raise a NotImplementedError:

            print(" ... Error: could not do something or missing something")
            raise NotImplementedError('need a error handling or specific item to continue this implementation')
PatNichols commented 8 months ago

@smaticka @BenjaminRuston This is passing tests. The ci is still broken for the repo.