search

JCSDA-internal / ioda-converters

Various converters for getting obs data in and out of IODA
8 stars 2 forks source link

[Bug] bufr2ioda.x Crash When Requesting a Non-Existent Query for SATWND Conversion #1427

Closed spanNOAA closed 4 months ago

spanNOAA commented 7 months ago

Current behavior (describe the bug)

The program usually issues a warning message for a non-existing query and then moves on to the next one. But in the case of SATWND, it unexpectedly leads to a segmentation fault when requesting a non-existing query.

To Reproduce

What computer are you running on? Hera What compilers/modules are you using? spack-stack-1.5.0 Steps to reproduce the behavior

I have two examples to request non-existing queries for AIRCFT and SATWND. Both of them are on Hera: /scratch2/BMC/wrfruc/Sijie.Pan/iodaconv/SATWND_issue

Expected behavior

When running the "bufr2ioda.x bufr_ncep_prepbufr_aircft.yaml" command, numerous warning messages appear indicating non-existent queries. Conversely, executing "bufr2ioda.x bufr_ncep_prepbufr_satwnd.yaml" results in an immediate "Segmentation fault."

Additional information (optional)

rmclaren commented 7 months ago

The query */PRSLEVEL/Z___INFO/Z__EVENT/ZOB should be */Z___INFO/Z__EVENT/ZOB as PRSLEVEL is not a repeatable sequence (see the output for print_queries.x)... I know this is confusing as PRSLEVEL is usually present for the other data types in this file... So that will solve the issue, but I still need to look at why its crashing instead of giving a warning.

rmclaren commented 7 months ago

Fixed in pull request

PatNichols commented 4 months ago

@spanNOAA Can we close this one now?

spanNOAA commented 4 months ago

Yes. Thanks!

Sijie

On Mon, Feb 26, 2024 at 12:26 PM Patrick Nichols @.***> wrote:

@spanNOAA https://github.com/spanNOAA Can we close this one now?

— Reply to this email directly, view it on GitHub https://github.com/JCSDA-internal/ioda-converters/issues/1427#issuecomment-1965063996, or unsubscribe https://github.com/notifications/unsubscribe-auth/BB7NXEE3RGXTDD7QZICRRRTYVTOU7AVCNFSM6AAAAABAGT6JNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRVGA3DGOJZGY . You are receiving this because you were mentioned.Message ID: @.***>