JCSDA-internal / ioda-converters

Various converters for getting obs data in and out of IODA
8 stars 2 forks source link

option to retrieve only bending angle also add sub sat id #1430

Closed BenjaminRuston closed 6 months ago

BenjaminRuston commented 7 months ago

add an option to the call to allow for bending angle only to be retrieved from the input BUFR file

also leveraging the new WMO BUFR template retrieve the sub satellite ID t fix? What new capability does it add?

Issue(s) addressed

Resolves #1429

Dependencies

ecCodes 2.32.1 or greater

Checklist

BenjaminRuston commented 7 months ago

@huishao-r these changes are backward compatible for satelliteSubIdentification so earlier files that don't have it will still decode.

also this adds the --only_bending_angle option if one does not want refractivity and the profiles

huishao-r commented 6 months ago

When I ran this, I got failure. The old version is still working to me. I'll try to reinstall my code and see whether there is some other updates causing this.

I pushed a code change to allow the height to read from impact height for only_bang option. It works for me, instead of the original PR code. Will see whether CI tests pass or not.

PatNichols commented 6 months ago

@huishao-r The same ctest is still failing and there is a coding norms failure:

14 - iodaconv_gnssro_coding_norms (Failed) 130 - test_iodaconv_generic_gnssro_bufr (Failed)

huishao-r commented 6 months ago

@huishao-r The same ctest is still failing and there is a coding norms failure:

14 - iodaconv_gnssro_coding_norms (Failed) 130 - test_iodaconv_generic_gnssro_bufr (Failed)

Got it. I am running ctest locally so that I can see what went wrong. Will push changes once I get the fix.