Fix new coding style errors revealed by upgrading pycodestyle from 2.8.0 to 2.11.0

srherbener commented 7 months ago

Description

The upcoming spack-stack-1.6.0 release includes an upgrade for the pycodestyle package moving from the spack-stack-1.5.1 version, py-pycodestyle@2.8.0, to a newer version, py-pycodestyle@2.11.0. The pycodestyle 2.11.0 is flagging "no white space after keyword" errors (of which pycodestyle@2.8.0 did not). An example is "if(...):" where there is no space after "if". This passes in 2.8.0 and fails in 2.11.0.

This PR fixes all of these case and passes using pycodestyle 2.11.0.

Issue(s) addressed

Resolves #1433

Dependencies

List the other PRs that this PR is dependent on: None

Impact

Expected impact on downstream repositories: None

Checklist

[x] I have performed a self-review of my own code
[x] I have made corresponding changes to the documentation (N/A)
[x] I have run the unit tests before creating the PR
- iodaconv ctests pass with both pycodestyle versions 2.8.0 and 2.11.0

PatNichols commented 7 months ago

@BenjaminRuston Could you review this please? It's one of those quick reviews where no codde is actually changed just a new format to make coding norms.

srherbener commented 7 months ago

thanks @srherbener I run this manually often with the new stack assume still call it with just pycodestyle and not py-pycodestyle ?

py-<package_name> is the way spack names its package that contain python packages. The actual python packages contained in the spack packages remain named as they were. So, py-pycodestyle is only the spack name, and when using in python (ie running manually) it is pycodestyle. Hope this helps clarify.

JCSDA-internal / ioda-converters