search

JCSDA-internal / ioda-converters

Various converters for getting obs data in and out of IODA
8 stars 2 forks source link

Add handling to avoid processing FFT remapping for missing satellite p… #1444

Closed emilyhcliu closed 5 months ago

emilyhcliu commented 5 months ago

Description

This is a bug fix Add handling to avoid processing FFP remapping for missing satellite platforms from BUFR file Users may list out all possible platforms from BUFR in the YAML (see YAML section below) The FFT remapping part of the code should have handling to avoid processing data from missing satellite platforms in the BUFR file.

Example of the Buggy situation: Input ATMS BUFR contains data from one platform: n20 only, but users listed more. The current BUFR converter already handle the missing satellites from the bufr file. BUFR converter will print out warning " PRE-MAIN-WARNING Skipped category npp n21"

But, the FFT remapping code does not handle this.
The code change in this PR is to avoid processing FFTP remapping for missint satellite platforms from BUFR file.

        splits:
          satId:
            category:
              variable: satelliteIdentifier
              map:
                _224: npp
                _225: n20
                _226: n21

The same fix should be in IODA feature/bufr_backend

Issue(s) addressed

Resolves #1443

Dependencies

List the other PRs that this PR is dependent on:

Impact

Expected impact on downstream repositories:

Checklist

PatNichols commented 5 months ago

@emilyhcliu You have a coding norms failure in the ctests./jcsda/ioda-bundle/iodaconv/src/bufr/BufrParser/Exports/Variables/RemappedBrightnessTemperatureVariable.cpp:74: Lines should be <= 100 characters long [whitespace/line_length] [2] /jcsda/ioda-bundle/iodaconv/src/bufr/BufrParser/Exports/Variables/RemappedBrightnessTemperatureVariable.cpp:75: Lines should be <= 100 characters long [whitespace/line_length] [2]

emilyhcliu commented 5 months ago

@emilyhcliu You have a coding norms failure in the ctests./jcsda/ioda-bundle/iodaconv/src/bufr/BufrParser/Exports/Variables/RemappedBrightnessTemperatureVariable.cpp:74: Lines should be <= 100 characters long [whitespace/line_length] [2] /jcsda/ioda-bundle/iodaconv/src/bufr/BufrParser/Exports/Variables/RemappedBrightnessTemperatureVariable.cpp:75: Lines should be <= 100 characters long [whitespace/line_length] [2]

@PatNichols Thanks for checking. I should have done the checking. I will update. Thanks.

emilyhcliu commented 5 months ago

@emilyhcliu You have a coding norms failure in the ctests./jcsda/ioda-bundle/iodaconv/src/bufr/BufrParser/Exports/Variables/RemappedBrightnessTemperatureVariable.cpp:74: Lines should be <= 100 characters long [whitespace/line_length] [2] /jcsda/ioda-bundle/iodaconv/src/bufr/BufrParser/Exports/Variables/RemappedBrightnessTemperatureVariable.cpp:75: Lines should be <= 100 characters long [whitespace/line_length] [2]

@PatNichols Thanks for checking. I should have done the checking. I will update. Thanks. @PatNichols I removed one space for both lines. They are exact 100 in length now. :-)