Ioda-converters YAML for the [3D]-RTMA aircar data

PraveenKumar-NOAA commented 5 months ago

Description

This PR adds an ioda-converters YAML for the [3D]-RTMA AIRCAR data.

The following files are new/ modified:

testinput/bufr_ncep_rtma_aircar.yaml
testinput/rtma_ru.t0000z.aircar_NC004004.tm00.bufr_d
testoutput/rtma_ru.t0000z.aircar_NC004004.tm00.nc
CMakeLists.txt

The ioda-validation test is performed and following results were obtained:

Final results: errors: 0 warnings: 0

The validation of the output ioda obs is also performed in: #1373

Issue(s) addressed

Resolves #1391

Dependencies

None

Impact

None

Checklist

[x] I have performed a self-review of my own code
[x] I have made corresponding changes to the documentation
[ ] I have run the unit tests before creating the PR

MatthewMorris-NOAA commented 5 months ago

@PraveenKumar-NOAA This looks good to me, but I'm curious about the 3 failed checks. Is this a cause for concern?

PraveenKumar-NOAA commented 5 months ago

@PraveenKumar-NOAA This looks good to me, but I'm curious about the 3 failed checks. Is this a cause for concern?

@MatthewMorris-NOAA I don't think, let us see what @PatNichols says about it.

PatNichols commented 5 months ago

@PraveenKumar-NOAA The one failed test is directly related to this PR. The error message is: ERROR /tmp/root/spack-stage/spack-stage-nccmp-1.9.0.1-br2cpqht43dbgly2cax2zzc3ee2z7tow/spack-src/src/nccmp_state.c:163 File not found: testoutput/rtma_ru.t0000z.aircar_NC004004.tm00.nc

PatNichols commented 5 months ago

@PraveenKumar-NOAA It looks like you never added your output file to the CMakeLists.txt file.

JCSDA-internal / ioda-converters