JCSDA-internal / ioda-converters

Various converters for getting obs data in and out of IODA
8 stars 2 forks source link

augmenting OSW decoder for CYGNSS #1449

Closed smaticka closed 5 months ago

smaticka commented 5 months ago

Description

Ocean surface data of wind speed retrieval (no direction) is available from NOAA CYGNSS as netCDF files. A converter is needed to bring the data into IODA format to be used in JEDI.

NEED TO CONFIRM THE USAGE OF sv_num AS THE stationIdentification.

Command for testing: python3 $JEDI_SRC/iodaconv/src/hdf5/cygnss_2ioda.py -i cygnss-20240124T214830Z-001/cyg.ddmi.s20220216-000001-e20220216-235959.l2.wind_trackgridsize25km_NOAAv1.2_L1a21.d21.nc -o 20220216T0000Z_cygnss.nc

Issue(s) addressed

Partial of https://github.com/JCSDA-internal/ioda-converters/issues/1452

Checklist

PatNichols commented 5 months ago

@smaticka you nedd to fix coding norms and then this one will be good to go.

smaticka commented 5 months ago

@smaticka you nedd to fix coding norms and then this one will be good to go.

@PatNichols do you know how I can see the code norms that need to be changed? for python code, I run the pycode style command. not sure for c++. when I click on the Details link in the Checks section, I see nothing in the bottom 3 (green checks) and I get access denied to the top 3 (red x's).

image
PatNichols commented 5 months ago

@smaticka you nedd to fix coding norms and then this one will be good to go.

@PatNichols do you know how I can see the code norms that need to be changed? for python code, I run the pycode style command. not sure for c++. when I click on the Details link in the Checks section, I see nothing in the bottom 3 (green checks) and I get access denied to the top 3 (red x's). image

@smaticka You can run autopep8 on your code which will change most things to a format that pycodestyle accepts. Here are the errors if you want to change them by hand. ./cygnss_2ioda.py:52:1: E122 continuation line missing indentation or outdented ./cygnss_2ioda.py:129:33: W291 trailing whitespace ./cygnss_2ioda.py:204:92: E261 at least two spaces before inline comment ./cygnss_2ioda.py:223:1: E302 expected 2 blank lines, found 1

smaticka commented 5 months ago

@smaticka you nedd to fix coding norms and then this one will be good to go.

@PatNichols do you know how I can see the code norms that need to be changed? for python code, I run the pycode style command. not sure for c++. when I click on the Details link in the Checks section, I see nothing in the bottom 3 (green checks) and I get access denied to the top 3 (red x's). image

@smaticka You can run autopep8 on your code which will change most things to a format that pycodestyle accepts. Here are the errors if you want to change them by hand. ./cygnss_2ioda.py:52:1: E122 continuation line missing indentation or outdented ./cygnss_2ioda.py:129:33: W291 trailing whitespace ./cygnss_2ioda.py:204:92: E261 at least two spaces before inline comment ./cygnss_2ioda.py:223:1: E302 expected 2 blank lines, found 1

Could you type the exact command please? When I run autopep8 _filename_ I get that the command is not found.

smaticka commented 5 months ago

@smaticka you nedd to fix coding norms and then this one will be good to go.

@PatNichols do you know how I can see the code norms that need to be changed? for python code, I run the pycode style command. not sure for c++. when I click on the Details link in the Checks section, I see nothing in the bottom 3 (green checks) and I get access denied to the top 3 (red x's). image

@smaticka You can run autopep8 on your code which will change most things to a format that pycodestyle accepts. Here are the errors if you want to change them by hand. ./cygnss_2ioda.py:52:1: E122 continuation line missing indentation or outdented ./cygnss_2ioda.py:129:33: W291 trailing whitespace ./cygnss_2ioda.py:204:92: E261 at least two spaces before inline comment ./cygnss_2ioda.py:223:1: E302 expected 2 blank lines, found 1

Could you type the exact command please? When I run autopep8 _filename_ I get that the command is not found.

@PatNichols follow up: I ran pip install autopep8 and then when I run the same command, it just prints out the entire file (no code review)