add support for both h5 and n4 CYGNSS files

BenjaminRuston commented 5 months ago

Description

support CYGNSS file in both h5 and netcdf4 formats

Issue(s) addressed

Resolves #1465

Checklist

[ ] I have performed a self-review of my own code

smaticka commented 5 months ago

@BenjaminRuston, as discussed, rather than making all of these additions, we could instead run this os command to make the files compatible with the current converter.

nccopy -k 'netCDF-4' cyg.ddmi.s20240109-000001-e20240109-235959.l2.wind_trackgridsize25km_NOAAv1.2_L1a21.d21.nc cyg_copy.nc

@ashley314. Wanted to keep you in the loop on this converter change (which we won't do). Essentially the newer cygnss files are not compatible with hd5f python package, but the os/terminal command above will convert the files to then be used by the current converter as is. Ben said this nccopy -k 'netCDF-4' will belong in the ingest script, so wanted you to be aware that this will be needed as a check. Some sort of check similar to lines 100-103 that Ben added might be needed and then as an else option, using nccopy to convert. (nccopy -k can also check the filetype I believe). etc etc :)

smaticka commented 5 months ago

@BenjaminRuston can we close this now?

ashley314 commented 5 months ago

Thanks @smaticka for the information. I'll make note of it for when we add these obs to the suite

BenjaminRuston commented 5 months ago

yes thanks @smaticka agree this should be done on the ingest step, and will discuss with the data provider if they can't remedy this directly on production

JCSDA-internal / ioda-converters