JCSDA-internal / ioda-converters

Various converters for getting obs data in and out of IODA
8 stars 2 forks source link

Change the predictor emissivityK to emissivityJacobian following the naming convention #1518

Closed huishao-r closed 1 month ago

huishao-r commented 1 month ago

run-ci-on-draft=true

Description

emissivityK is no longer supported. Instead, emissivityJacobian should be used. This PR is to fix this.

Issue(s) addressed

Resolves #1517

Dependencies

None

Impact

CI should pass with test yaml and test reference

Checklist

BenjaminRuston commented 1 month ago

@huishao-r is this ready for review?

huishao-r commented 1 month ago

Sorry, I converted it back to draft. I realized there are more variables to be updated. @junmeiban I found some other predictor names might not be right either. Please be cautious when using this converter at this point. I'll push my changes to the same branch.

huishao-r commented 1 month ago

@junmeiban I fixed the predictor names for all. I realized this converter was updated before the naming convention was finalized. I fixed the predictor names in the branch now. Would you like to test it from your side? Sorry about this.

junmeiban commented 1 month ago

@junmeiban I fixed the predictor names for all. I realized this converter was updated before the naming convention was finalized. I fixed the predictor names in the branch now. Would you like to test it from your side? Sorry about this.

Thank you so much! I will test it in MPAS-JEDI.

junmeiban commented 1 month ago

I generated new satbias_*.nc4 files by using satbias_converter.yaml (updated by @huishao-r ); Tested in MPAS-JEDI and ran successfully. Other satbias_converter*.yaml and satbias files are also corrected by @huishao-r

junmeiban commented 1 month ago

Many thanks @huishao-r !