search

JCSDA-internal / soca

Sea-ice Ocean Coupled Assimilation
Apache License 2.0
12 stars 4 forks source link

Feature/add structured grid and cmakelist edit #1057

Open jrocha22 opened 2 months ago

jrocha22 commented 2 months ago

Description

PR to add a ConvertToStructuredGrid executable to alter files to be in structured lat/lon grid for easier post processing. CMakeLists.txt file edited to run executable

Issue(s) addressed

No associated issue number but resolves grid difficulties that might arise from further processing of files

Testing

New executable tested with twelve different high resolution (1440x1080x75) files and two low resolution (72x35x25) files from MOM6. Variables pulled were sea surface temperature and sea water potential temperature. All files ran through with no issues.
Executable tested with Hercules. Are the changes covered by ctests? No (If not, tests should be added first.)

CoryMartin-NOAA commented 2 months ago

@jrocha22 can you modify the PR description to fill out the requested items (describe what this adds, how it was tested, etc.)

CoryMartin-NOAA commented 2 months ago

@jrocha22 we should talk about possibly adding a test that exercises this, if @travissluka wants us to add one

travissluka commented 2 months ago

@jrocha22 we should talk about possibly adding a test that exercises this, if @travissluka wants us to add one

yes, please add a ctest using one of the low res 5 deg files in soca, @jrocha22 let me know if you need guidance on how to add a ctest to soca.

side note: wow, I'm surprised that works with such little code, good job model interface team! (@fmahebert )

jrocha22 commented 2 months ago

@jrocha22 we should talk about possibly adding a test that exercises this, if @travissluka wants us to add one

yes, please add a ctest using one of the low res 5 deg files in soca, @jrocha22 let me know if you need guidance on how to add a ctest to soca.

side note: wow, I'm surprised that works with such little code, good job model interface team! (@fmahebert )

@travissluka some ctest guidance would be great! thank you

CoryMartin-NOAA commented 2 months ago

Thanks @travissluka , @jrocha22 's summer with us is coming to a close, but either myself or @catherinethomas-noaa will help get this over the finish line with a test if Juliette is unable to