SPRINT: Tidy up 1dvar names

JCSDA-internal / ufo-data

Tier-1 test files for ufo repository

1 stars 0 forks source link

SPRINT: Tidy up 1dvar names #275

Closed mikecooke77 closed 1 year ago

mikecooke77 commented 1 year ago

Names tidied up in TestReference and TestReferenceOneDVar so that ctests pass.

To be merged with:

[ ] https://github.com/JCSDA-internal/ufo/pull/2549

All ufo ctests should pass:

[x] are ufo ctests associated with the above ticket passing?

brettcandy commented 1 year ago

can you check the file thats goneinto lfs correctly? i have downloaded it and get a failure if i try to perform ncdump ncdump -h atms_n20_obs_20191230T0000_rttov.nc4 > new NetCDF: HDF error Location: file ncdump.c; line 1705

mikecooke77 commented 1 year ago

can you check the file thats goneinto lfs correctly? i have downloaded it and get a failure if i try to perform ncdump ncdump -h atms_n20_obs_20191230T0000_rttov.nc4 > new NetCDF: HDF error Location: file ncdump.c; line 1705

It looks OK to me. Could you try ncdump again on a new terminal window. I've had conflicting hdf paths in the past that have caused this kind of issue.

brettcandy commented 1 year ago

can you check the file thats goneinto lfs correctly? i have downloaded it and get a failure if i try to perform ncdump ncdump -h atms_n20_obs_20191230T0000_rttov.nc4 > new NetCDF: HDF error Location: file ncdump.c; line 1705

It looks OK to me. Could you try ncdump again on a new terminal window. I've had conflicting hdf paths in the past that have caused this kind of issue.

Thanks Mike, that solved the issue. I have checked the three update files and confirmed via ncdump -h that the variable names follow the new convention and make sense